Text-Based Install Team Ryan Holden Mark Godwin Thea Gab Danny Pearson ======================= [ OFFICIAL LIST OF KNOW BUGS ] ======================= ======================= [BUG NAME] Newline reader bug [DESCRIPTION] Each .txt file that resides in the data/ and data/help/ directories must be terminated with a newline character. Text corruption occurs on certain screens without a terminating newline character. This bug is believed to reside within the reader.c file. [FILED] 06/15/09 - 11:07AM ======================= [BUG NAME] ASCII Range Character Restriction [DESCRIPTION] The text installer currently uses ASCII ranges to restrict specific characters throughout the installer. We are aware that there exists a much better means of achieving this functionality. Ascii character ranges are used in the following callback functions: alter_fdisk.c: void notify_alter_fdisk_part_screen(int KEY_CODE) date_time.c: void notify_date_time_screen(int KEY_CODE) users.c : void notify_users_screen(int KEY_CODE) Specific Examples: Users screen: Computer name does not allow a hyphen. (There are many more) [FILED] 06/15/09 - 11:21AM ======================= [BUG NAME] Set NVLIST for Blank Field Values [DESCRIPTION] Currently a minimum length requirement is enforced on every form field, because there is no logic to account for setting the nvlist values correctly in the case of a blank field. Minimum length requirements are enforced on fields initialized in the following files: alter_fdisk.c date_time.c users.c Nvlist values are set within installation_screen.c [FILED] 06/15/09 - 12:16PM ======================= [BUG NAME] freeStructs segmentation fault [DESCRIPTION] Memory associated with the country/continent/timezone structs is never freed due to a segmentation fault that occurs. The affected calls have been commented out withing the freeStructs() function which is called from main.c. [FILED] 06/15/09 - 1:10PM ======================= [BUG NAME] busy wait on orchestrator discovery [DESCRIPTION] In main.c there is a while loop that waits for orchestrator discovery to finish discovering the disks. This needs to be changed into some kind of timeout or pause [FILED] 06/16/09 - 10:44AM ======================= [BUG NAME] no check for errors during an install [DESCRIPTION] The callbacks in install.c checking the progress of om_perform_install do not check to see if this function has returned an error throughout or at the end of an install. [FILED] 06/16/09- 10:46AM ======================= [BUG NAME] Pretend Install seg faults [DESCRIPTION] In install.h when _PRETEND_INSTALLATION_ is TRUE the progress bar will only progress by typing in characters and then will seg fault at the end. [FILED] 06/16/09- 12:31PM ======================= [BUG NAME] Checking for null values [DESCRIPTION] When accessing originalpartitions, modified partitions, etc. in disk.c, alter_fdisk_part.c, and fdisk_part.c these should probably check for NULL values so that the orchestrator functions won't fail if bad data is passed in [FILED] 06/16/09- 12:45PM ======================= [BUG NAME] free_part_info() [DESCRIPTION] The free_part_info() function in orchestrator_wrappers.c should check to see if the variables are already NULL before freeing them [FILED] 06/16/09- 1:32PM ======================= [BUG NAME] install doesn't work on 64-bit virtual box [DESCRIPTION] The install has been tested on 32 and 64-bit machines and on a 32-bit Virtual Box, but doesn't appear to be working on a 64-bit Virtual box [FILED] 06/16/09- 1:35PM ======================= [BUG NAME] OM_ATTR_LOCALES_LIST never gets set [DESCRIPTION] When setting the nvlist to contain the proper values in install.c we never set the locales list, thus OM_ATTR_LOCALES_LIST is never set [FILED] 06/16/09- 1:54PM ======================= [BUG NAME] Help screens text files not implemented [DESCRIPTION] Files exist for the help screens and they are integrated with the code, but the actual help text needs to be inserted into those files, along with coordinates to specify the start of where each block of text will go [FILED] 06/16/09- 1:56PM ======================= [BUG NAME] Text-based installer only supports initial installations, not upgrades [DESCRIPTION] [FILED] 06/16/09- 1:58PM ======================= [BUG NAME] Users screen shows notifications when it shouldn't [DESCRIPTION] When a button is pressed (such as F10) that brings up a popup box a notification (red line at bottom of screen) is also shown,saying that this character is not allowed [FILED] 06/16/09- 1:59PM ======================= [BUG NAME] "USB keyboard" appears at bottom of screen [DESCRIPTION] Every once in a while, when running the install, "USB keyboard" will print to the bottom of the screen and remain there for the rest of the install (normally, it flashes across the top of the screen right after the keyboard is selected). Could possibly be an issue with screen size and wrapping? [FILED] 06/16/09- 2:14PM ======================== [BUG NAME] Installer only supported in English [DESCRIPTION] TEXTINFOPATH points to the path of our current data files, which are written, in English. This path could potentially be set in the code to allow for other data directories that contain other languages for the installer. [FILED] 06/16/09 2:30PM ======================== [BUG NAME] Log not in correct place after install [DESCRIPTION] There is a log available at /tmp/install_log and after reboot at /var/sadm/system/logs/install_log but not at /var/logs/install. This might need to be copied over. [FILED] 06/16/09 2:35PM ======================== [BUG NAME] Corruption on alter fdisk screen [DESCRIPTION] On some computers, running the installation code causes some corruption to occur on the alter fdisk screen (junk characters written over the second partition name). This could possibly be due to some kind of memory issue. Only occurs going forward a screen not backwards [FILED] 06/16/09 2:47PM ======================== [BUG NAME] Free space is -0.0 in alter_fdisk_part.c [DESCRIPTION] The free space printed out to the screen shows a -0.0 instead of 0.0 [FILED] 06/16/09 2:49PM ======================== [BUG NAME] Specific notifications don't show up when calling installationdisk_validate() [DESCRIPTION] Both the alter_fdisk_part.c and fdisk_part.c screens call the installationdisk_validate() function contained in disk.c. Right now, if this fails an error message will be printed out saying the disk could not validate. But there are more specific error notifications in the installationdisk_validate() function that are currently commented out. This should probably be changed. Currently only one notification screen can be shown at a time. [FILED] 06/16/09 2:56PM ======================== [BUG NAME] Summary screen shouldn't scroll if all the info fits on one screen [DESCRIPTION] summary_screen.c currently is scrollable. Probably shouldn't scroll if all the summary info can fit on one page [FILED] 06/16/09 3:46PM ======================== [BUG NAME] Warnings and Errors overwrite the text installer screen. [DESCRIPTION] When using the text installer, any error messages and warnings are printed on top of the text install windows. These mess up the appearance of the installer. A temporary fix is to alter the /etc/syslogd.conf file to prevent those messages from being directed to /dev/console An ideal fix is to modify the service we created to have a single instance of the installer/service. In addition, add some functionality to the service that mimics the logic of the legacy text installer for Solaris; take control of the console through the propval 'need_session' [FILED] 06/16/09 3:50PM ======================== [BUG NAME] Percentage displays too dark when progress screen goes over it [DESCRIPTION] On the screen that shows the progress bar for the install (progress_screen.c), the percentage number shows up fine until the progress bar passes over it. Then, the numbers are a little dark to read well. [FILED] 06/16/09 3:58PM