Code Review for crossbow-gate

Prepared by:Crossbow Team (crossbow) on Mon Aug 18 09:52:17 PDT 2008
Workspace:/ws/crossbow-gate
Compare against: /net/onnv/export/snapshot/onnv_94
Summary of changes: 14197 lines changed: 12617 ins; 1021 del; 559 mod; 30121 unchg
Patch of changes: crossbow-gate.patch
Printable review: crossbow-gate.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 2 ins; 0 del; 1 mod; 929 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dladm/dladm.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
1719 lines changed: 1056 ins; 476 del; 187 mod; 5223 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dlmgmtd/dlmgmt_main.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
8 lines changed: 0 ins; 6 del; 2 mod; 372 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/svc/milestone/net-physical 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
9 lines changed: 8 ins; 0 del; 1 mod; 451 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/vna/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 2 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/vna/vna.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
7 lines changed: 1 ins; 0 del; 6 mod; 305 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
2 lines changed: 0 ins; 0 del; 2 mod; 588 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlaggr.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
18 lines changed: 5 ins; 1 del; 12 mod; 1462 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
190 lines changed: 99 ins; 82 del; 9 mod; 939 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdllink.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
31 lines changed: 24 ins; 4 del; 3 mod; 156 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/linkprop.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
1070 lines changed: 924 ins; 65 del; 81 mod; 1948 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcsu/prototype_com 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 2 ins; 0 del; 1 mod; 1657 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWhea/prototype_com 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 2 ins; 0 del; 1 mod; 1439 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/etc/exception_list_i386 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
10 lines changed: 8 ins; 1 del; 1 mod; 1088 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/etc/exception_list_sparc 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
10 lines changed: 8 ins; 1 del; 1 mod; 1168 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/tools/scripts/bfu.sh 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
4 lines changed: 3 ins; 0 del; 1 mod; 8023 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile.cmd 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
5 lines changed: 4 ins; 0 del; 1 mod; 496 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/acctadm/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
7 lines changed: 2 ins; 1 del; 4 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/acctadm/aconf.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
99 lines changed: 94 ins; 1 del; 4 mod; 566 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/acctadm/aconf.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
9 lines changed: 4 ins; 1 del; 4 mod; 86 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/acctadm/main.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
64 lines changed: 52 ins; 1 del; 11 mod; 288 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/acctadm/res.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
53 lines changed: 47 ins; 1 del; 5 mod; 350 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dladm/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
2 lines changed: 1 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/dladm/dladm.xcl 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
223 lines changed: 132 ins; 32 del; 59 mod; 173 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/dladm/vnic.conf 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/flowadm/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/flowadm/flowadm.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
1780 lines changed: 1780 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/flowadm/flowadm.conf 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/flowadm/flowadm.xcl 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/flowadm/flowprop.conf 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/rcm_daemon/Makefile.com 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
5 lines changed: 4 ins; 0 del; 1 mod; 210 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/rcm_daemon/common/vnic_rcm.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
1331 lines changed: 1331 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/Makefile 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
8 lines changed: 5 ins; 0 del; 3 mod; 66 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/Makefile.com 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
6 lines changed: 2 ins; 0 del; 4 mod; 50 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/dladm_parselog.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
1754 lines changed: 1754 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/flowattr.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
406 lines changed: 406 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/flowprop.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
828 lines changed: 828 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdladm.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
312 lines changed: 293 ins; 17 del; 2 mod; 490 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdladm.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
81 lines changed: 78 ins; 0 del; 3 mod; 122 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdladm_impl.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
70 lines changed: 60 ins; 9 del; 1 mod; 70 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/libdlflow.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
871 lines changed: 871 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/libdlflow.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/libdlflow_impl.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/libdlstat.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
685 lines changed: 685 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/libdlstat.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlvlan.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
279 lines changed: 1 ins; 263 del; 15 mod; 67 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlvlan.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 1 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlvnic.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
541 lines changed: 387 ins; 46 del; 108 mod; 203 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/libdlvnic.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
31 lines changed: 14 ins; 7 del; 10 mod; 50 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/llib-ldladm 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
3 lines changed: 2 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/mapfile-vers 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
52 lines changed: 48 ins; 2 del; 2 mod; 128 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/lib/libdladm/common/propfuncs.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
728 lines changed: 728 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libdladm/common/secobj.c 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
12 lines changed: 1 ins; 4 del; 7 mod; 627 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkgdefs/SUNWcnetr/prototype_com 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
4 lines changed: 3 ins; 0 del; 1 mod; 75 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/flow.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
184 lines changed: 184 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/uts/common/sys/dld_ioc.h 

PSARC 2006/357 Crossbow - Network Virtualization and Resource Partitioning
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /ws/onnv-gate/public/bin/webrev (vers 2008/07/09). Webrev is maintained by the OpenSolaris project. The latest version may be obtained here.